govet: implement analyzers config #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernado
force-pushed
the
govet-config
branch
3 times, most recently
from
fc1260e to
c656992
Compare
ernado
force-pushed
the
govet-config
branch
from
c656992 to
7de6ae1
Compare
I'm not sure why CI is failing.
jirfag
reviewed
Sep 15, 2019
pkg/golinters/govet.go
Outdated
| } | ||
| for _, n := range cfg.Disable { | ||
| if n == name { | ||
| return true |
There was a problem hiding this comment.
I guess it should be
Suggested change
| return true | |
| return false |
There was a problem hiding this comment.
You are right, nice catch!
I've also added a corresponding test for that function.
| return false | ||
| } | ||
|
|
||
| func analyzersFromConfig(cfg *config.GovetSettings) []*analysis.Analyzer { |
There was a problem hiding this comment.
please, add minimal validation to (r *FileReader) validateConfig() by calling something like:
func (cfg *config.GovetSettings) Validate() error {
if cfg.EnableAll && cfg.DisableAll {
return errors.New("enable-all and disable-all can't be combined")
}
if cfg.EnableAll && len(cfg.Enable) != 0) {
return errors.New("enable-all and enable can't be combined")
}
if cfg.DisableAll && len(cfg.Disable) != 0) {
return errors.New("disable-all and disable can't be combined")
}
return nil
}There was a problem hiding this comment.
Done, thank you.
We probably want to validate that cfg.Enable contains valid analyzer names, but I'm not sure how to do it in that scope.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #696, #446
Please feel free to request any changes.